chrome/browser/ui/webui/net_internals/net_internals_ui.cc - Issue 1211933005: Initial (partial) implementation of HPKP violation reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 1211933005: Initial (partial) implementation of HPKP violation reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: style fixes, comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

index d91b9df1cb817951cdf1ed2bdae52fc0d2fcccb5..a151d610d546472b46d803c54a6bc9bb829ee390 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

@@ -827,7 +827,7 @@ void NetInternalsMessageHandler::IOThreadImpl::OnHSTSAdd(

transport_security_state->AddHSTS(domain, expiry, sts_include_subdomains);

transport_security_state->AddHPKP(domain, expiry, pkp_include_subdomains,

- hashes);

+ hashes, std::string());

}

void NetInternalsMessageHandler::IOThreadImpl::OnHSTSDelete(

« no previous file with comments | « chrome/browser/ssl/chrome_fraudulent_certificate_reporter_unittest.cc ('k') | net/http/certificate_report_sender.h » ('j') | no next file with comments »