chrome/browser/ssl/chrome_fraudulent_certificate_reporter.cc - Issue 1211933005: Initial (partial) implementation of HPKP violation reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/chrome_fraudulent_certificate_reporter.cc

Issue 1211933005: Initial (partial) implementation of HPKP violation reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: style fixes, comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/certificate_reporting_test_utils.cc ('k') | chrome/browser/ssl/chrome_fraudulent_certificate_reporter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/chrome_fraudulent_certificate_reporter.cc

diff --git a/chrome/browser/ssl/chrome_fraudulent_certificate_reporter.cc b/chrome/browser/ssl/chrome_fraudulent_certificate_reporter.cc

index e24d71ad28abb0f6e3e5ffe9d70d1ae98e9dc94e..3ea25ebebfb61be2932bf0aeccc7cca2bdfab16e 100644

--- a/chrome/browser/ssl/chrome_fraudulent_certificate_reporter.cc

+++ b/chrome/browser/ssl/chrome_fraudulent_certificate_reporter.cc

@@ -7,6 +7,7 @@

#include "base/profiler/scoped_tracker.h"

#include "chrome/browser/net/certificate_error_reporter.h"

#include "chrome/browser/ssl/certificate_error_report.h"

+#include "net/http/certificate_report_sender.h"

#include "net/ssl/ssl_info.h"

#include "net/url_request/url_request_context.h"

#include "url/gurl.h"

@@ -25,7 +26,7 @@ ChromeFraudulentCertificateReporter::ChromeFraudulentCertificateReporter(

: certificate_reporter_(new chrome_browser_net::CertificateErrorReporter(

request_context,

GURL(kFraudulentCertificateUploadEndpoint),

- chrome_browser_net::CertificateErrorReporter::DO_NOT_SEND_COOKIES)) {

+ net::CertificateReportSender::DO_NOT_SEND_COOKIES)) {

}

ChromeFraudulentCertificateReporter::ChromeFraudulentCertificateReporter(