Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1211913005: Add a sky media service to make it possible to play a sound. (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a sky media service to make it possible to play a sound. I didn't exactly follow the android API, but pretty close. Also started a java/common implementation for things like DataPipeUtils. I only needed the ability to copy from a data pipe to a file, so that's the only function we have so far. Fixes https://github.com/domokit/mojo/issues/270 R=abarth@chromium.org, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1635aee07f7b54e42a47e67917c945bc6a055fb7

Patch Set 1 #

Patch Set 2 : Add example #

Total comments: 2

Patch Set 3 : Fixed style #

Patch Set 4 : not cpp #

Patch Set 5 : Ready for review #

Total comments: 10

Patch Set 6 : Updated per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -9 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/java/BUILD.gn View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
A mojo/java/org/chromium/mojo/common/DataPipeUtils.java View 1 2 3 4 5 1 chunk +100 lines, -0 lines 0 comments Download
M sky/apk/demo/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java View 2 chunks +9 lines, -0 lines 0 comments Download
A sky/sdk/example/widgets/piano.dart View 1 2 3 4 5 1 chunk +100 lines, -0 lines 0 comments Download
A + sky/services/media/BUILD.gn View 2 chunks +9 lines, -5 lines 0 comments Download
A sky/services/media/media.mojom View 1 2 3 4 5 1 chunk +17 lines, -0 lines 0 comments Download
A sky/services/media/src/org/domokit/media/MediaPlayerImpl.java View 1 2 3 4 5 1 chunk +110 lines, -0 lines 0 comments Download
A sky/services/media/src/org/domokit/media/MediaServiceImpl.java View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
M sky/shell/android/org/domokit/sky/shell/ServiceRegistry.java View 1 2 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
eseidel
5 years, 5 months ago (2015-07-01 00:52:14 UTC) #1
eseidel
I forgot to add the new mojo/java directory I added, oops.
5 years, 5 months ago (2015-07-01 02:02:18 UTC) #2
abarth-chromium
https://codereview.chromium.org/1211913005/diff/20001/sky/sdk/example/widgets/piano.dart File sky/sdk/example/widgets/piano.dart (right): https://codereview.chromium.org/1211913005/diff/20001/sky/sdk/example/widgets/piano.dart#newcode39 sky/sdk/example/widgets/piano.dart:39: final List<Map<int, Color> > pallets = [ s/> >/>>/ ...
5 years, 5 months ago (2015-07-01 15:57:22 UTC) #4
abarth-chromium
lgtm https://codereview.chromium.org/1211913005/diff/80001/mojo/java/org/chromium/mojo/common/DataPipeUtils.java File mojo/java/org/chromium/mojo/common/DataPipeUtils.java (right): https://codereview.chromium.org/1211913005/diff/80001/mojo/java/org/chromium/mojo/common/DataPipeUtils.java#newcode7 mojo/java/org/chromium/mojo/common/DataPipeUtils.java:7: // TODO(eseidel): Can we not depend on Android? ...
5 years, 5 months ago (2015-07-01 17:52:14 UTC) #5
eseidel
5 years, 5 months ago (2015-07-01 19:29:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
1635aee07f7b54e42a47e67917c945bc6a055fb7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698