Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 1211903002: Apply early retrun in SelectionController (Closed)

Created:
4 years, 10 months ago by Miyoung Shin(c)
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Apply early retrun in SelectionController BUG=483376 TEST=n/a; No behavior changes. R=yosin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197900

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -70 lines) Patch
M Source/core/editing/SelectionController.cpp View 1 6 chunks +79 lines, -70 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Miyoung Shin(c)
4 years, 10 months ago (2015-06-25 15:57:11 UTC) #1
yosin_UTC9
lgtm w/ nits https://codereview.chromium.org/1211903002/diff/1/Source/core/editing/SelectionController.cpp File Source/core/editing/SelectionController.cpp (right): https://codereview.chromium.org/1211903002/diff/1/Source/core/editing/SelectionController.cpp#newcode204 Source/core/editing/SelectionController.cpp:204: if (!(innerNode && innerNode->layoutObject() && m_mouseDownMayStartSelect)) ...
4 years, 10 months ago (2015-06-26 01:00:28 UTC) #2
Miyoung Shin(c)
https://codereview.chromium.org/1211903002/diff/1/Source/core/editing/SelectionController.cpp File Source/core/editing/SelectionController.cpp (right): https://codereview.chromium.org/1211903002/diff/1/Source/core/editing/SelectionController.cpp#newcode204 Source/core/editing/SelectionController.cpp:204: if (!(innerNode && innerNode->layoutObject() && m_mouseDownMayStartSelect)) On 2015/06/26 01:00:28, ...
4 years, 10 months ago (2015-06-26 04:44:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211903002/20001
4 years, 10 months ago (2015-06-26 08:40:47 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-26 09:44:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197900

Powered by Google App Engine
This is Rietveld 408576698