Issue 1211883004: Update Stocks.apk build tech

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1211883004: Update Stocks.apk build tech (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Update Stocks.apk build tech Instead of having a one-off //sky/apk/stocks, we now use the |sky_app| GN template to create Stocks.apk directly from //sky/sdk/example/stocks. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9abd86c55350c1ae1a4b0715f2202566bb96dbad

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -81 lines)			Patch
M	sky/BUILD.gn	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	sky/apk/stocks/AndroidManifest.xml	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	sky/apk/stocks/BUILD.gn	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	sky/apk/stocks/org/domokit/stocks/StocksActivity.java	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	sky/sdk/README.md	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/example/BUILD.gn	View	1 chunk	+4 lines, -1 line	0 comments	Download
A +	sky/sdk/example/stocks/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sky/sdk/example/stocks/apk/AndroidManifest.xml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-06-27 07:41:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9abd86c55350c1ae1a4b0715f2202566bb96dbad (presubmit successful).