Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1211883003: Revert of [tracing] Send unique tracing process id for cross-process memory dumps identification. (Closed)

Created:
5 years, 6 months ago by Mike Wittman
Modified:
5 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, nasko+codewatch_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tracing] Send unique tracing process id for cross-process memory dumps identification. (patchset #15 id:320001 of https://codereview.chromium.org/1173263004/) Reason for revert: Appears to regress sizes PERF_REGRESS: chrome-si/initializers (14.29%), chrome-si/initializers (14.29%) https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/5461 Original issue's description: > [tracing] Send unique tracing process id for cross-process memory dumps identification. > > The memory shared between browser and renderer must be identified with > the same unique id for memory dumps in tracing. Currently the child > process is not aware of its unique child process id. But, the child > process id cannot be exposed in the child process (see discussion in > crrev.com/1155683009). > > So, a hash of the child process id allocated by the browser process is > sent to child process along with begin tracing message and will be > exposed in the child process MemoryDumpManager. The allocator that > needs to create a global guid will use the id to identify memory dumps. > > See the design doc https://goo.gl/ncMfUV for more details. > > BUG=497726 > > Committed: https://crrev.com/a3e7c30a16e711b59226da21f993522ee47ac674 > Cr-Commit-Position: refs/heads/master@{#336210} TBR=dcheng@chromium.org,jam@chromium.org,picksi@google.com,primiano@chromium.org,ssid@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497726 Committed: https://crrev.com/7bab3b2fe54de87069eea91bc21743955063b213 Cr-Commit-Position: refs/heads/master@{#336232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -72 lines) Patch
M base/trace_event/memory_dump_manager.h View 5 chunks +0 lines, -35 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M components/tracing/child_trace_message_filter.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/tracing/child_trace_message_filter.cc View 3 chunks +1 line, -7 lines 0 comments Download
M components/tracing/tracing_messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/trace_message_filter.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/tracing/trace_message_filter.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Wittman
Created Revert of [tracing] Send unique tracing process id for cross-process memory dumps identification.
5 years, 6 months ago (2015-06-25 19:40:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211883003/1
5 years, 6 months ago (2015-06-25 19:41:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 19:42:26 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 19:43:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bab3b2fe54de87069eea91bc21743955063b213
Cr-Commit-Position: refs/heads/master@{#336232}

Powered by Google App Engine
This is Rietveld 408576698