Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(123)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1211813002: DevTools: allow injecting CSS rules without breaking styles sidebar. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: allow injecting CSS rules without breaking styles sidebar. R=lushnikov BUG=178410 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197913

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1008 lines, -55 lines) Patch
M LayoutTests/http/tests/inspector-protocol/css-protocol-test.js View 1 2 3 chunks +9 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/inspector-protocol/css/cssom-matching-rules.html View 1 2 3 1 chunk +176 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/css/cssom-matching-rules-expected.txt View 1 2 1 chunk +179 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/css/cssom-matching-rules-multiple.html View 1 2 3 4 1 chunk +112 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/css/cssom-matching-rules-multiple-expected.txt View 1 2 3 4 1 chunk +141 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/css/cssom-set-style-text-expected.txt View 1 2 1 chunk +163 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParser.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSParserImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +8 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 2 3 4 5 6 2 chunks +10 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 3 4 5 6 19 chunks +205 lines, -36 lines 0 comments Download

Depends on Patchset:

Issue 1177983006 Patch 60001

Dependent Patchsets:

Issue 1213693005 Patch 1

Messages

Total messages: 10 (3 generated)
pfeldman
4 years, 10 months ago (2015-06-25 12:59:38 UTC) #1
lushnikov
this needs tests https://codereview.chromium.org/1211813002/diff/20001/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp (right): https://codereview.chromium.org/1211813002/diff/20001/Source/core/inspector/InspectorStyleSheet.cpp#newcode1486 Source/core/inspector/InspectorStyleSheet.cpp:1486: return m_flatRules.at(it->value); i think you want ...
4 years, 10 months ago (2015-06-25 15:44:12 UTC) #2
pfeldman
comments addressed, ready for review.
4 years, 10 months ago (2015-06-25 17:50:54 UTC) #3
pfeldman
https://codereview.chromium.org/1211813002/diff/40001/Source/core/css/parser/CSSParser.h File Source/core/css/parser/CSSParser.h (right): https://codereview.chromium.org/1211813002/diff/40001/Source/core/css/parser/CSSParser.h#newcode56 Source/core/css/parser/CSSParser.h:56: static void parseSheetForInspector(const CSSParserContext&, StyleSheetContents*, const String&, CSSParserObserver&); @timloh: ...
4 years, 10 months ago (2015-06-25 17:52:32 UTC) #5
lushnikov
lgtm
4 years, 10 months ago (2015-06-26 12:16:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211813002/120001
4 years, 10 months ago (2015-06-26 12:46:13 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-26 13:50:54 UTC) #10
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197913

Powered by Google App Engine
This is Rietveld 408576698