src/debug.cc - Issue 1211803002: Reland 2 "Keep a canonical list of shared function infos."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 1211803002: Reland 2 "Keep a canonical list of shared function infos." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add test case Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index c414e23d39b9bc86580efa349163c59dbf215441..f814db84868032201feebecc059560e810a7bcd4 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -2079,7 +2079,7 @@ Handle<Object> Debug::FindSharedFunctionInfoInScript(Handle<Script> script,

// If the candidate is not compiled, compile it to reveal any inner

// functions which might contain the requested source position. This

// will compile all inner functions that cannot be compiled without a

- // context, because Compiler::BuildFunctionInfo checks whether the

+ // context, because Compiler::GetSharedFunctionInfo checks whether the

// debugger is active.

MaybeHandle<Code> maybe_result = target_function.is_null()

? Compiler::GetUnoptimizedCode(target)

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/factory.cc » ('j') | no next file with comments »