Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1211793002: Rename safe_json_parser component to safe_json. (Closed)

Created:
5 years, 6 months ago by Bernhard Bauer
Modified:
5 years, 6 months ago
CC:
chromium-reviews, tapted, Matt Giuca, extensions-reviews_chromium.org, tfarina, pam+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename safe_json_parser component to safe_json. This is in preparation for adding a JSON sanitizer to the component. It's also a shorter name :) TBR=jochen@chromium.org BUG=501333 Committed: https://crrev.com/f0e64aa0e8c48b45e48a23a4e291fad7ef9b89c7 Cr-Commit-Position: refs/heads/master@{#336167}

Patch Set 1 #

Total comments: 6

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -492 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_data_fetcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_install_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_json_parser_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_site_list.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/search/common/json_response_fetcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/web_resource/chrome_web_resource_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/safe_json_parser_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/utility/safe_json_parser_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/components.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + components/safe_json.gypi View 1 3 chunks +9 lines, -9 lines 0 comments Download
A + components/safe_json/BUILD.gn View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + components/safe_json/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/safe_json/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/safe_json/safe_json_parser.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/safe_json/safe_json_parser.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A + components/safe_json/safe_json_parser_message_filter.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/safe_json/safe_json_parser_message_filter.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/safe_json/safe_json_parser_messages.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/safe_json/safe_json_parser_messages.cc View 1 chunk +6 lines, -6 lines 0 comments Download
D components/safe_json_parser.gypi View 1 chunk +0 lines, -49 lines 0 comments Download
D components/safe_json_parser/BUILD.gn View 1 chunk +0 lines, -36 lines 0 comments Download
D components/safe_json_parser/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D components/safe_json_parser/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/safe_json_parser/safe_json_parser.h View 1 chunk +0 lines, -66 lines 0 comments Download
D components/safe_json_parser/safe_json_parser.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D components/safe_json_parser/safe_json_parser_message_filter.h View 1 chunk +0 lines, -38 lines 0 comments Download
D components/safe_json_parser/safe_json_parser_message_filter.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D components/safe_json_parser/safe_json_parser_messages.h View 1 chunk +0 lines, -37 lines 0 comments Download
D components/safe_json_parser/safe_json_parser_messages.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Bernhard Bauer
Please review! FYI, the WIP JSON sanitizer is here: https://codereview.chromium.org/1203083002/
5 years, 6 months ago (2015-06-25 13:11:10 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/1211793002/diff/1/components/safe_json.gypi File components/safe_json.gypi (right): https://codereview.chromium.org/1211793002/diff/1/components/safe_json.gypi#newcode23 components/safe_json.gypi:23: 'SAFE_JSON_PARSER_IMPLEMENTATION', Update this define? https://codereview.chromium.org/1211793002/diff/1/components/safe_json/BUILD.gn File components/safe_json/BUILD.gn (right): ...
5 years, 6 months ago (2015-06-25 14:40:50 UTC) #3
Bernhard Bauer
Thanks! Jochen: TBR (pure rename). https://codereview.chromium.org/1211793002/diff/1/components/safe_json.gypi File components/safe_json.gypi (right): https://codereview.chromium.org/1211793002/diff/1/components/safe_json.gypi#newcode23 components/safe_json.gypi:23: 'SAFE_JSON_PARSER_IMPLEMENTATION', On 2015/06/25 14:40:49, ...
5 years, 6 months ago (2015-06-25 14:48:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211793002/20001
5 years, 6 months ago (2015-06-25 14:49:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-25 15:54:16 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 15:55:07 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f0e64aa0e8c48b45e48a23a4e291fad7ef9b89c7
Cr-Commit-Position: refs/heads/master@{#336167}

Powered by Google App Engine
This is Rietveld 408576698