Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 1211753002: Fix traced StyleResolverStats (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 1846 matching lines...) Expand 10 before | Expand all | Expand 10 after
1857 1857
1858 // Pseudo element removal and similar may only work with these flags still s et. Reset them after the style recalc. 1858 // Pseudo element removal and similar may only work with these flags still s et. Reset them after the style recalc.
1859 styleEngine().resetCSSFeatureFlags(resolver.ensureUpdatedRuleFeatureSet()); 1859 styleEngine().resetCSSFeatureFlags(resolver.ensureUpdatedRuleFeatureSet());
1860 resolver.clearStyleSharingList(); 1860 resolver.clearStyleSharingList();
1861 1861
1862 ASSERT(!needsStyleRecalc()); 1862 ASSERT(!needsStyleRecalc());
1863 ASSERT(!childNeedsStyleRecalc()); 1863 ASSERT(!childNeedsStyleRecalc());
1864 ASSERT(inStyleRecalc()); 1864 ASSERT(inStyleRecalc());
1865 ASSERT(styleResolver() == &resolver); 1865 ASSERT(styleResolver() == &resolver);
1866 m_lifecycle.advanceTo(DocumentLifecycle::StyleClean); 1866 m_lifecycle.advanceTo(DocumentLifecycle::StyleClean);
1867 RefPtr<TracedValue> counters = shouldRecordStats ? resolver.stats()->toTrace dValue() : nullptr; 1867 if (shouldRecordStats) {
1868 TRACE_EVENT_END2("blink,blink_style", "Document::updateStyle", 1868 TRACE_EVENT_END2("blink,blink_style", "Document::updateStyle",
1869 "resolverAccessCount", styleEngine().resolverAccessCount() - initialReso lverAccessCount, 1869 "resolverAccessCount", styleEngine().resolverAccessCount() - initial ResolverAccessCount,
1870 "counters", counters); 1870 "counters", resolver.stats()->toTracedValue());
1871 } else {
1872 TRACE_EVENT_END1("blink,blink_style", "Document::updateStyle",
1873 "resolverAccessCount", styleEngine().resolverAccessCount() - initial ResolverAccessCount);
1874 }
1871 } 1875 }
1872 1876
1873 void Document::notifyLayoutTreeOfSubtreeChanges() 1877 void Document::notifyLayoutTreeOfSubtreeChanges()
1874 { 1878 {
1875 if (!layoutView()->wasNotifiedOfSubtreeChange()) 1879 if (!layoutView()->wasNotifiedOfSubtreeChange())
1876 return; 1880 return;
1877 1881
1878 m_lifecycle.advanceTo(DocumentLifecycle::InLayoutSubtreeChange); 1882 m_lifecycle.advanceTo(DocumentLifecycle::InLayoutSubtreeChange);
1879 1883
1880 layoutView()->handleSubtreeModifications(); 1884 layoutView()->handleSubtreeModifications();
(...skipping 3885 matching lines...) Expand 10 before | Expand all | Expand 10 after
5766 #ifndef NDEBUG 5770 #ifndef NDEBUG
5767 using namespace blink; 5771 using namespace blink;
5768 void showLiveDocumentInstances() 5772 void showLiveDocumentInstances()
5769 { 5773 {
5770 WeakDocumentSet& set = liveDocumentSet(); 5774 WeakDocumentSet& set = liveDocumentSet();
5771 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5775 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5772 for (Document* document : set) 5776 for (Document* document : set)
5773 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5777 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5774 } 5778 }
5775 #endif 5779 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698