Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1211753002: Fix traced StyleResolverStats (Closed)

Created:
5 years, 6 months ago by dstockwell
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Fix traced StyleResolverStats In r197513[1] we changed to pass a RefPtr<TracedValue> to a TRACE_EVENT macro, but this resulted in tracing coercion to bool. This patch reverts to using PassRefPtr but makes which macro we use conditional on whether we have a second argument. [1] https://codereview.chromium.org/1199563003/ BUG=501634 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dstockwell
Open to better ideas. I tried to pass counters.release() but the trace macros do not ...
5 years, 6 months ago (2015-06-25 06:03:14 UTC) #2
dstockwell
5 years, 6 months ago (2015-06-26 01:10:29 UTC) #3
oystein (OOO til 10th of July)
lgtm Yeah I have some thoughts on how to make TraceValues safer, but that's a ...
5 years, 6 months ago (2015-06-26 02:01:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211753002/1
5 years, 6 months ago (2015-06-26 02:28:37 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 03:25:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197882

Powered by Google App Engine
This is Rietveld 408576698