src/log.cc - Issue 121173009: String:WriteUtf8: Add REPLACE_INVALID_UTF8 option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 121173009: String:WriteUtf8: Add REPLACE_INVALID_UTF8 option (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: DISALLOW_INVALID_UTF8 flag and fixes Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index 95362c0910d28163fb1d72d0f47c38c262fe289c..6083673d09a07f79d011cf9169aae86b4151202d 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -120,6 +120,7 @@ class CodeEventLogger::NameBuffer {

} else {

int char_length = unibrow::Utf8::Length(c, previous);

if (utf8_pos_ + char_length > kUtf8BufferSize) break;

+ // @TODO Fix this Utf8::Encode call site somehow.

unibrow::Utf8::Encode(utf8_buffer_ + utf8_pos_, c, previous);

utf8_pos_ += char_length;

}