Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Unified Diff: Source/core/svg/SVGAltGlyphDefElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAltGlyphDefElement.h ('k') | Source/core/svg/SVGAltGlyphElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAltGlyphDefElement.cpp
diff --git a/Source/core/svg/SVGAltGlyphDefElement.cpp b/Source/core/svg/SVGAltGlyphDefElement.cpp
index 4924ec5f3c5669ff147653a2d1d455cf2003a5d5..5f54325cbb8f8db36ab71b7c3e404595bf713720 100644
--- a/Source/core/svg/SVGAltGlyphDefElement.cpp
+++ b/Source/core/svg/SVGAltGlyphDefElement.cpp
@@ -39,7 +39,7 @@ PassRefPtr<SVGAltGlyphDefElement> SVGAltGlyphDefElement::create(Document& docume
return adoptRef(new SVGAltGlyphDefElement(document));
}
-bool SVGAltGlyphDefElement::hasValidGlyphElements(Vector<String>& glyphNames) const
+bool SVGAltGlyphDefElement::hasValidGlyphElements(Vector<AtomicString>& glyphNames) const
{
// Spec: http://www.w3.org/TR/SVG/text.html#AltGlyphDefElement
// An 'altGlyphDef' can contain either of the following:
@@ -91,7 +91,7 @@ bool SVGAltGlyphDefElement::hasValidGlyphElements(Vector<String>& glyphNames) co
for (Node* child = firstChild(); child; child = child->nextSibling()) {
if (!foundFirstAltGlyphItem && child->hasTagName(SVGNames::glyphRefTag)) {
fountFirstGlyphRef = true;
- String referredGlyphName;
+ AtomicString referredGlyphName;
if (toSVGGlyphRefElement(child)->hasValidGlyphElement(referredGlyphName))
glyphNames.append(referredGlyphName);
@@ -105,7 +105,7 @@ bool SVGAltGlyphDefElement::hasValidGlyphElements(Vector<String>& glyphNames) co
}
} else if (!fountFirstGlyphRef && child->hasTagName(SVGNames::altGlyphItemTag)) {
foundFirstAltGlyphItem = true;
- Vector<String> referredGlyphNames;
+ Vector<AtomicString> referredGlyphNames;
// As the spec says "The first 'altGlyphItem' in which all referenced glyphs
// are available is chosen."
« no previous file with comments | « Source/core/svg/SVGAltGlyphDefElement.h ('k') | Source/core/svg/SVGAltGlyphElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698