Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: Source/core/svg/SVGFESpecularLightingElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGFEOffsetElement.cpp ('k') | Source/core/svg/SVGFETileElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2005 Oliver Hunt <oliver@nerget.com> 4 * Copyright (C) 2005 Oliver Hunt <oliver@nerget.com>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 { 204 {
205 if (SVGFELightElement::findLightElement(this) != lightElement) 205 if (SVGFELightElement::findLightElement(this) != lightElement)
206 return; 206 return;
207 207
208 // The light element has different attribute names so attrName can identify the requested attribute. 208 // The light element has different attribute names so attrName can identify the requested attribute.
209 primitiveAttributeChanged(attrName); 209 primitiveAttributeChanged(attrName);
210 } 210 }
211 211
212 PassRefPtr<FilterEffect> SVGFESpecularLightingElement::build(SVGFilterBuilder* f ilterBuilder, Filter* filter) 212 PassRefPtr<FilterEffect> SVGFESpecularLightingElement::build(SVGFilterBuilder* f ilterBuilder, Filter* filter)
213 { 213 {
214 FilterEffect* input1 = filterBuilder->getEffectById(in1CurrentValue()); 214 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(in1CurrentV alue()));
215 215
216 if (!input1) 216 if (!input1)
217 return 0; 217 return 0;
218 218
219 RefPtr<LightSource> lightSource = SVGFELightElement::findLightSource(this); 219 RefPtr<LightSource> lightSource = SVGFELightElement::findLightSource(this);
220 if (!lightSource) 220 if (!lightSource)
221 return 0; 221 return 0;
222 222
223 RenderObject* renderer = this->renderer(); 223 RenderObject* renderer = this->renderer();
224 if (!renderer) 224 if (!renderer)
225 return 0; 225 return 0;
226 226
227 ASSERT(renderer->style()); 227 ASSERT(renderer->style());
228 Color color = renderer->style()->svgStyle()->lightingColor(); 228 Color color = renderer->style()->svgStyle()->lightingColor();
229 229
230 RefPtr<FilterEffect> effect = FESpecularLighting::create(filter, color, surf aceScaleCurrentValue(), specularConstantCurrentValue(), 230 RefPtr<FilterEffect> effect = FESpecularLighting::create(filter, color, surf aceScaleCurrentValue(), specularConstantCurrentValue(),
231 specularExponentCurrentValue(), kernelUnitLengthXCurrentValue(), kernelU nitLengthYCurrentValue(), lightSource.release()); 231 specularExponentCurrentValue(), kernelUnitLengthXCurrentValue(), kernelU nitLengthYCurrentValue(), lightSource.release());
232 effect->inputEffects().append(input1); 232 effect->inputEffects().append(input1);
233 return effect.release(); 233 return effect.release();
234 } 234 }
235 235
236 } 236 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGFEOffsetElement.cpp ('k') | Source/core/svg/SVGFETileElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698