Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: Source/core/svg/SVGFEDisplacementMapElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Oliver Hunt <oliver@nerget.com> 2 * Copyright (C) 2006 Oliver Hunt <oliver@nerget.com>
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 if (attrName == SVGNames::inAttr || attrName == SVGNames::in2Attr) { 141 if (attrName == SVGNames::inAttr || attrName == SVGNames::in2Attr) {
142 invalidate(); 142 invalidate();
143 return; 143 return;
144 } 144 }
145 145
146 ASSERT_NOT_REACHED(); 146 ASSERT_NOT_REACHED();
147 } 147 }
148 148
149 PassRefPtr<FilterEffect> SVGFEDisplacementMapElement::build(SVGFilterBuilder* fi lterBuilder, Filter* filter) 149 PassRefPtr<FilterEffect> SVGFEDisplacementMapElement::build(SVGFilterBuilder* fi lterBuilder, Filter* filter)
150 { 150 {
151 FilterEffect* input1 = filterBuilder->getEffectById(in1CurrentValue()); 151 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(in1CurrentV alue()));
152 FilterEffect* input2 = filterBuilder->getEffectById(in2CurrentValue()); 152 FilterEffect* input2 = filterBuilder->getEffectById(AtomicString(in2CurrentV alue()));
153 153
154 if (!input1 || !input2) 154 if (!input1 || !input2)
155 return 0; 155 return 0;
156 156
157 RefPtr<FilterEffect> effect = FEDisplacementMap::create(filter, xChannelSele ctorCurrentValue(), yChannelSelectorCurrentValue(), scaleCurrentValue()); 157 RefPtr<FilterEffect> effect = FEDisplacementMap::create(filter, xChannelSele ctorCurrentValue(), yChannelSelectorCurrentValue(), scaleCurrentValue());
158 FilterEffectVector& inputEffects = effect->inputEffects(); 158 FilterEffectVector& inputEffects = effect->inputEffects();
159 inputEffects.reserveCapacity(2); 159 inputEffects.reserveCapacity(2);
160 inputEffects.append(input1); 160 inputEffects.append(input1);
161 inputEffects.append(input2); 161 inputEffects.append(input2);
162 return effect.release(); 162 return effect.release();
163 } 163 }
164 164
165 } 165 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGFEDiffuseLightingElement.cpp ('k') | Source/core/svg/SVGFEDropShadowElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698