Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: Source/core/svg/SVGAElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/svg/SVGResources.cpp ('k') | Source/core/svg/SVGAltGlyphDefElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 if (focused() && isEnterKeyKeydownEvent(event)) { 154 if (focused() && isEnterKeyKeydownEvent(event)) {
155 event->setDefaultHandled(); 155 event->setDefaultHandled();
156 dispatchSimulatedClick(event); 156 dispatchSimulatedClick(event);
157 return; 157 return;
158 } 158 }
159 159
160 if (isLinkClick(event)) { 160 if (isLinkClick(event)) {
161 String url = stripLeadingAndTrailingHTMLSpaces(hrefCurrentValue()); 161 String url = stripLeadingAndTrailingHTMLSpaces(hrefCurrentValue());
162 162
163 if (url[0] == '#') { 163 if (url[0] == '#') {
164 Element* targetElement = treeScope().getElementById(url.substrin g(1)); 164 Element* targetElement = treeScope().getElementById(AtomicString (url.substring(1)));
165 if (targetElement && isSVGSMILElement(*targetElement)) { 165 if (targetElement && isSVGSMILElement(*targetElement)) {
166 toSVGSMILElement(targetElement)->beginByLinkActivation(); 166 toSVGSMILElement(targetElement)->beginByLinkActivation();
167 event->setDefaultHandled(); 167 event->setDefaultHandled();
168 return; 168 return;
169 } 169 }
170 // Only allow navigation to internal <view> anchors. 170 // Only allow navigation to internal <view> anchors.
171 if (targetElement && !targetElement->hasTagName(SVGNames::viewTa g)) 171 if (targetElement && !targetElement->hasTagName(SVGNames::viewTa g))
172 return; 172 return;
173 } 173 }
174 174
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 236
237 return SVGGraphicsElement::childShouldCreateRenderer(child); 237 return SVGGraphicsElement::childShouldCreateRenderer(child);
238 } 238 }
239 239
240 bool SVGAElement::willRespondToMouseClickEvents() 240 bool SVGAElement::willRespondToMouseClickEvents()
241 { 241 {
242 return isLink() || SVGGraphicsElement::willRespondToMouseClickEvents(); 242 return isLink() || SVGGraphicsElement::willRespondToMouseClickEvents();
243 } 243 }
244 244
245 } // namespace WebCore 245 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/SVGResources.cpp ('k') | Source/core/svg/SVGAltGlyphDefElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698