Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1211693002: Remove Site Information from the Origin Info Bubble. (Closed)

Created:
5 years, 6 months ago by palmer
Modified:
5 years, 5 months ago
Reviewers:
Robert Sesek, msw, Ted C, felt
CC:
chromium-reviews, markusheintz_, tfarina, lgarron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Site Information from the Origin Info Bubble. It's not keyed to authenticated information (e.g. public keys), and thus is not a reliable way to make security decisions. BUG=503212 Committed: https://crrev.com/f9b680ad47f8cdfe95bb9a2f53d76a1e22544c52 Cr-Commit-Position: refs/heads/master@{#338104}

Patch Set 1 #

Patch Set 2 : Fix Views and Cocoa layouts. #

Total comments: 2

Patch Set 3 : Removed unnecessary #include. #

Total comments: 18

Patch Set 4 : Rebase, and remove more code as msw advised. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -204 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/android/connection_info_popup_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/android/connection_info_popup_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 4 chunks +0 lines, -41 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 2 3 3 chunks +0 lines, -19 lines 3 comments Download
M chrome/browser/ui/website_settings/website_settings.h View 1 2 3 4 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 3 5 chunks +2 lines, -52 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_unittest.cc View 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
palmer
Please take a look. Thanks! felt: Generally tedchoc: chrome/browser/ui/android msw: chrome/browser/ui, chrome/browser/ui/views rsesek: chrome/browser/ui/cocoa
5 years, 6 months ago (2015-06-26 17:34:10 UTC) #2
Ted C
On 2015/06/26 17:34:10, palmer wrote: > Please take a look. Thanks! > > felt: Generally ...
5 years, 6 months ago (2015-06-26 17:42:50 UTC) #3
Robert Sesek
cocoa/ LGTM
5 years, 6 months ago (2015-06-26 17:46:08 UTC) #4
felt
https://codereview.chromium.org/1211693002/diff/20001/chrome/browser/ui/website_settings/website_settings.cc File chrome/browser/ui/website_settings/website_settings.cc (right): https://codereview.chromium.org/1211693002/diff/20001/chrome/browser/ui/website_settings/website_settings.cc#newcode27 chrome/browser/ui/website_settings/website_settings.cc:27: #include "chrome/browser/history/history_service_factory.h" Can you kill this (and perhaps other) ...
5 years, 6 months ago (2015-06-26 17:46:27 UTC) #5
palmer
https://codereview.chromium.org/1211693002/diff/20001/chrome/browser/ui/website_settings/website_settings.cc File chrome/browser/ui/website_settings/website_settings.cc (right): https://codereview.chromium.org/1211693002/diff/20001/chrome/browser/ui/website_settings/website_settings.cc#newcode27 chrome/browser/ui/website_settings/website_settings.cc:27: #include "chrome/browser/history/history_service_factory.h" > Can you kill this (and perhaps ...
5 years, 6 months ago (2015-06-26 18:06:25 UTC) #6
felt
lgtm for chrome/browser/ui/website_settings/ and generally
5 years, 6 months ago (2015-06-26 20:19:43 UTC) #7
palmer
Arg, I forgot to add msw!
5 years, 6 months ago (2015-06-26 20:42:11 UTC) #9
msw
https://codereview.chromium.org/1211693002/diff/40001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc (left): https://codereview.chromium.org/1211693002/diff/40001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc#oldcode616 chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:616: page_info_content_, Can you remove |page_info_content_|? https://codereview.chromium.org/1211693002/diff/40001/chrome/browser/ui/website_settings/website_settings.cc File chrome/browser/ui/website_settings/website_settings.cc (right): ...
5 years, 5 months ago (2015-06-29 19:29:48 UTC) #10
palmer
https://codereview.chromium.org/1211693002/diff/40001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc (left): https://codereview.chromium.org/1211693002/diff/40001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc#oldcode616 chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:616: page_info_content_, On 2015/06/29 19:29:48, msw wrote: > Can you ...
5 years, 5 months ago (2015-07-07 23:33:26 UTC) #11
msw
lgtm with a nit/q. https://codereview.chromium.org/1211693002/diff/60001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc (right): https://codereview.chromium.org/1211693002/diff/60001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc#newcode649 chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:649: pane->AddChildView(new views::Separator(views::Separator::HORIZONTAL)); nit: Did you ...
5 years, 5 months ago (2015-07-08 01:43:11 UTC) #12
palmer
https://codereview.chromium.org/1211693002/diff/60001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc (right): https://codereview.chromium.org/1211693002/diff/60001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc#newcode649 chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:649: pane->AddChildView(new views::Separator(views::Separator::HORIZONTAL)); > nit: Did you intend to leave ...
5 years, 5 months ago (2015-07-09 18:11:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211693002/60001
5 years, 5 months ago (2015-07-09 18:14:15 UTC) #16
msw
still lgtm, sorry for my confusion. https://codereview.chromium.org/1211693002/diff/60001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc (right): https://codereview.chromium.org/1211693002/diff/60001/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc#newcode649 chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:649: pane->AddChildView(new views::Separator(views::Separator::HORIZONTAL)); On ...
5 years, 5 months ago (2015-07-09 18:14:50 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-09 18:56:15 UTC) #18
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 18:58:35 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f9b680ad47f8cdfe95bb9a2f53d76a1e22544c52
Cr-Commit-Position: refs/heads/master@{#338104}

Powered by Google App Engine
This is Rietveld 408576698