Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1211663002: Fix evaluation order of Object.prototype.hasOwnProperty (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix evaluation order of Object.prototype.hasOwnProperty We need to do the ToName before the ToObject. BUG=v8:4229 LOG=N R=adamk Committed: https://crrev.com/f4e39a8c1f68aa1cc7a3e5292760ecf563388cf0 Cr-Commit-Position: refs/heads/master@{#29272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M src/v8natives.js View 1 chunk +9 lines, -6 lines 0 comments Download
A + test/mjsunit/has-own-property-evaluation-order.js View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-24 21:44:34 UTC) #1
adamk
lgtm
5 years, 6 months ago (2015-06-24 21:49:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211663002/1
5 years, 6 months ago (2015-06-24 22:01:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 22:30:44 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 22:31:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4e39a8c1f68aa1cc7a3e5292760ecf563388cf0
Cr-Commit-Position: refs/heads/master@{#29272}

Powered by Google App Engine
This is Rietveld 408576698