Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 1211613002: Timeline: check category presence in list, not string equality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 1211613002: Timeline: check category presence in list, not string equality (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js

index 02d5ed5c0e202cadec7abbaa601af3c543d120fb..d1a6953c556f1755e4de564d048050151b9de5c3 100644

--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -545,7 +545,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

}

var category = WebInspector.TimelineUIUtils.eventStyle(event).category;

if (WebInspector.TracingModel.isAsyncPhase(event.phase)) {

- if (event.category === WebInspector.TracingModel.ConsoleEventCategory)

+ if (event.hasCategory(WebInspector.TracingModel.ConsoleEventCategory))

return this._consoleColorGenerator.colorForID(event.name);

var color = this._asyncColorByCategory[category.name];

if (color)