Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 1211613002: Timeline: check category presence in list, not string equality (Closed)

Created:
4 years, 10 months ago by caseq
Modified:
4 years, 10 months ago
Reviewers:
alph, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Timeline: check category presence in list, not string equality ... when testing for trace event category. Trace event categories are comma-separated list and individual itmes may come and go, so it's never correct to compare string category list for equality against a single category. Split them on comma and check category presence instead. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197843

Patch Set 1 #

Total comments: 1

Patch Set 2 : Array -> Set #

Patch Set 3 : fixed tracing-session-id.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -27 lines) Patch
M LayoutTests/inspector/tracing-session-id.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/console-timeline.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/worker-events.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components_lazy/FilmStripModel.js View 2 chunks +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/TracingModel.js View 1 14 chunks +43 lines, -13 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
caseq
4 years, 10 months ago (2015-06-24 17:36:29 UTC) #2
caseq
4 years, 10 months ago (2015-06-24 17:36:31 UTC) #3
alph
https://codereview.chromium.org/1211613002/diff/1/Source/devtools/front_end/sdk/TracingModel.js File Source/devtools/front_end/sdk/TracingModel.js (right): https://codereview.chromium.org/1211613002/diff/1/Source/devtools/front_end/sdk/TracingModel.js#newcode612 Source/devtools/front_end/sdk/TracingModel.js:612: return this._parsedCategories.indexOf(categoryName) >= 0; I'd expect it to be ...
4 years, 10 months ago (2015-06-25 09:50:15 UTC) #4
caseq
Done, ptal.
4 years, 10 months ago (2015-06-25 14:54:22 UTC) #5
yurys
lgtm
4 years, 10 months ago (2015-06-25 15:38:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211613002/20001
4 years, 10 months ago (2015-06-25 15:44:16 UTC) #8
commit-bot: I haz the power
Exceeded global retry quota
4 years, 10 months ago (2015-06-25 16:57:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211613002/40001
4 years, 10 months ago (2015-06-25 17:08:55 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 18:51:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197843

Powered by Google App Engine
This is Rietveld 408576698