Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1211593003: Remove unnecessary TEXTBC_LIBS makefile definition. (Closed)

Created:
5 years, 6 months ago by Karl
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unnecessary TEXTBC_LIBS makefile definition. Jan correctly pointed out that this makefie definition was redundant since -lLLVMNaClBitTestUtils was already defined in LLVM_LIBS_LIST. Removing the definition and simplifying makefile. BUG=None R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=28f3f731a7c8a82c1af570b3d04146584dd8cd3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Makefile.standalone View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Karl
5 years, 6 months ago (2015-06-24 16:29:46 UTC) #2
John
lgtm
5 years, 6 months ago (2015-06-24 16:31:48 UTC) #3
Karl
5 years, 6 months ago (2015-06-24 16:32:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
28f3f731a7c8a82c1af570b3d04146584dd8cd3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698