Issue 1211593002: Revert of Oilpan: promptly finalize XMLHttpRequestProgressEventThrottle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1211593002: Revert of Oilpan: promptly finalize XMLHttpRequestProgressEventThrottle. (Closed)

Created:
5 years, 6 months ago by sof

Modified:
5 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, tyoshino+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Oilpan: promptly finalize XMLHttpRequestProgressEventThrottle. (patchset #1 id:1 of https://codereview.chromium.org/1205843003/) Reason for revert: This is not well-formed as-is; XMLHttpRequestProgressEventThrottle is a part object & cannot be eagerly finalized on its own. Original issue's description: > Oilpan: promptly finalize XMLHttpRequestProgressEventThrottle. > > This timer object needs to promptly stop, otherwise we run the risk > of timers firing while the object is in non-valid state waiting to be > finalized by an ongoing lazy sweep. > > R=haraken > BUG=491488 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197736 TBR=oilpan-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197749

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

sof

Created Revert of Oilpan: promptly finalize XMLHttpRequestProgressEventThrottle.

5 years, 6 months ago (2015-06-24 15:49:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211593002/1

5 years, 6 months ago (2015-06-24 15:49:39 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197749

5 years, 6 months ago (2015-06-24 15:50:32 UTC) #3

Message was sent while issue was closed.

LGTM