Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1211583003: add drawImageNine (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add drawImageNine this also exposes nine-patch drawing directly to devices, and creates a shared iterator for unrolling a nine-patch into single rect->rect draws. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4c21dc5ddf3b482293ed34eead876d8d61a662c3

Patch Set 1 #

Patch Set 2 : update pictures #

Patch Set 3 : deferred support, bump picture version #

Patch Set 4 : expose nine-pataches directly to devices #

Patch Set 5 : uniformly check for null-pixelref #

Total comments: 6

Patch Set 6 : address comments from #9 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -95 lines) Patch
M gm/ninepatchstretch.cpp View 1 4 chunks +42 lines, -27 lines 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 3 4 3 chunks +20 lines, -2 lines 0 comments Download
M include/core/SkDevice.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 4 7 chunks +59 lines, -64 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download
A src/core/SkNinePatchIter.h View 1 2 3 4 5 1 chunk +42 lines, -0 lines 0 comments Download
A src/core/SkNinePatchIter.cpp View 1 chunk +72 lines, -0 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 3 chunks +16 lines, -1 line 0 comments Download
M src/core/SkRecordDraw.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/core/SkRecorder.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkRecords.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 2 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
reed1
Sky noted we didn't have a nine-patch version of images... note: time to GPUize both ...
5 years, 6 months ago (2015-06-25 02:11:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211583003/60001
5 years, 6 months ago (2015-06-25 02:11:53 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211583003/80001
5 years, 6 months ago (2015-06-25 02:38:02 UTC) #7
robertphillips
lgtm + nits https://codereview.chromium.org/1211583003/diff/80001/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/1211583003/diff/80001/include/core/SkPicture.h#newcode178 include/core/SkPicture.h:178: // V43: Added DRAW_IMAGE and DRAW_IMAGE_RECT ...
5 years, 6 months ago (2015-06-25 15:53:22 UTC) #9
reed1
https://codereview.chromium.org/1211583003/diff/80001/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/1211583003/diff/80001/include/core/SkPicture.h#newcode178 include/core/SkPicture.h:178: // V43: Added DRAW_IMAGE and DRAW_IMAGE_RECT opt codes to ...
5 years, 6 months ago (2015-06-25 19:12:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211583003/100001
5 years, 6 months ago (2015-06-25 19:25:40 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 19:32:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/4c21dc5ddf3b482293ed34eead876d8d61a662c3

Powered by Google App Engine
This is Rietveld 408576698