Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 1211583002: Check for null FrameView in PageAnimator::serviceScriptedAnimations. (Closed)

Created:
4 years, 10 months ago by skobes
Modified:
4 years, 10 months ago
Reviewers:
Ian Vollick, weiliangc
CC:
blink-reviews, shans, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check for null FrameView in PageAnimator::serviceScriptedAnimations. Speculative fix for crashes in ScrollableArea::serviceScrollAnimations. BUG=359028 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/page/PageAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
skobes
4 years, 10 months ago (2015-06-24 15:10:36 UTC) #2
weiliangc
LGTM Looks reasonable suspect. Thanks for looking into this!
4 years, 10 months ago (2015-06-24 17:26:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211583002/1
4 years, 10 months ago (2015-06-24 17:29:52 UTC) #5
skobes
+dstockwell for OWNERS
4 years, 10 months ago (2015-06-24 17:33:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/36301)
4 years, 10 months ago (2015-06-24 17:37:28 UTC) #9
skobes
+vollick for OWNERS
4 years, 10 months ago (2015-06-25 20:42:44 UTC) #11
Ian Vollick
On 2015/06/25 20:42:44, skobes wrote: > +vollick for OWNERS lgtm.
4 years, 10 months ago (2015-06-25 21:32:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211583002/1
4 years, 10 months ago (2015-06-25 21:37:56 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 22:37:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197863

Powered by Google App Engine
This is Rietveld 408576698