Source/platform/heap/BlinkGCMemoryDumpProvider.cpp - Issue 1211573006: Oilpan: Count # of collected Persistent handles and use it to estimate the live object size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

Issue 1211573006: Oilpan: Count # of collected Persistent handles and use it to estimate the live object size (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

diff --git a/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp b/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

index fcdcff1e611b4bbd405e37c3ae0c001af8a6fc44..ff89b4ecf7bf6988ebd569c2ea728c0eca094d44 100644

--- a/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

+++ b/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

@@ -34,7 +34,7 @@ bool BlinkGCMemoryDumpProvider::onMemoryDump(blink::WebProcessMemoryDump* memory

dumpName.append("/allocated_objects");

WebMemoryAllocatorDump* objectsDump = memoryDump->createMemoryAllocatorDump(dumpName);

objectsDump->AddScalar("size", "bytes", Heap::allocatedObjectSize() + Heap::markedObjectSize());

- objectsDump->AddScalar("estimated_live_object_size", "bytes", Heap::estimatedLiveObjectSize());

+ objectsDump->AddScalar("estimated_live_object_size", "bytes", Heap::liveObjectSizeAtLastSweep());

// Merge all dumps collected by Heap::collectGarbage.

memoryDump->takeAllDumpsFrom(m_currentProcessMemoryDump.get());

« no previous file with comments | « Source/bindings/core/v8/WrapperTypeInfo.h ('k') | Source/platform/heap/Handle.h » ('j') | no next file with comments »