Prevents panels attached to shelf from docking

ash/wm/window_state.cc

Index: ash/wm/window_state.cc
diff --git a/ash/wm/window_state.cc b/ash/wm/window_state.cc
index 0c86e28499dad3fb9662cd1baf1d9fd3e0fd3c3d..626ef2ed9b0d0304c0fb31161f785c937e907d50 100644
--- a/ash/wm/window_state.cc
+++ b/ash/wm/window_state.cc
@@ -33,7 +33,6 @@ WindowState::WindowState(aura::Window* window)
       ignored_by_shelf_(false),
       can_consume_system_keys_(false),
       top_row_keys_are_function_keys_(false),
-      window_resizer_(NULL),
       always_restores_to_restore_bounds_(false),
       hide_shelf_when_fullscreen_(true),
       animate_to_fullscreen_(true),
@@ -252,6 +251,22 @@ void WindowState::RemoveObserver(WindowStateObserver* observer) {
   observer_list_.RemoveObserver(observer);
 }
 
+bool WindowState::CreateDragDetails(aura::Window* window,
+                                    const gfx::Point& point_in_parent,
+                                    int window_component,
+                                    aura::client::WindowMoveSource source) {
+  scoped_ptr<DragDetails> details(new DragDetails(
+        window, point_in_parent, window_component, source));

[oshima, 2014/01/10 02:28:52]

how about:

drag_details_.reset(new ....)
if (drag_details_->is_resiable)
   return true;
drag_details_.reset();
return false;

if you don't like, you may leave it as is.

[varkha, 2014/01/10 06:13:07]

I prefer not to expose the details pointer even temporarily through
window_state->drag_details() accessor during DragDetails construction unless the
target is resizable. As it stands this is non-issue since is_resizable is just a
member but it seemed more explicit to me.

+  if (!details->is_resizable)
+    return false;
+  drag_details_.reset(details.release());

[oshima, 2014/01/10 02:41:38]

Forgot to mention. If you want to keep this way, please use Pass() instead.

[varkha, 2014/01/10 06:13:07]

Done.

+  return true;
+}
+
+void WindowState::DeleteDragDetails() {
+  drag_details_.reset();
+}
+
 void WindowState::OnWindowPropertyChanged(aura::Window* window,
                                           const void* key,
                                           intptr_t old) {