Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 1211523002: Table cells, rows, sections or column (groups) don't support margins. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Table cells, rows, sections or column (groups) don't support margins. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M Source/core/layout/LayoutBox.cpp View 1 chunk +5 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutTableRow.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
Not sure if the assertions I added make enough sense (albeit correct).
5 years, 6 months ago (2015-06-24 17:50:40 UTC) #1
leviw_travelin_and_unemployed
lgtm Makes sense to me.
5 years, 6 months ago (2015-06-24 19:03:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211523002/1
5 years, 6 months ago (2015-06-24 19:03:57 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 19:07:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197770

Powered by Google App Engine
This is Rietveld 408576698