Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1211453002: Reland "Keep a canonical list of shared function infos." (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev, Yang, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Keep a canonical list of shared function infos." This reverts commit 3164aa7483cb476da84895a3c9810015758fccf9. Committed: https://crrev.com/cacb646d80daa429f6915824a741f595db7d5044 Cr-Commit-Position: refs/heads/master@{#29282}

Patch Set 1 #

Patch Set 2 : small improvement #

Patch Set 3 : fix alwaysopt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -110 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/ast.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.h View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M src/compiler.cc View 1 2 9 chunks +70 lines, -34 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 10 chunks +26 lines, -13 lines 0 comments Download
M src/objects.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/typing.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-4121.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
This can be relanded once the fix for the code serializer to correctly deal with ...
5 years, 6 months ago (2015-06-24 11:06:29 UTC) #2
adamk
lgtm
5 years, 6 months ago (2015-06-24 14:49:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211453002/40001
5 years, 6 months ago (2015-06-25 09:00:42 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-25 09:09:36 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/cacb646d80daa429f6915824a741f595db7d5044 Cr-Commit-Position: refs/heads/master@{#29282}
5 years, 6 months ago (2015-06-25 09:09:54 UTC) #7
Yang
5 years, 6 months ago (2015-06-25 10:34:27 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1206263002/ by yangguo@chromium.org.

The reason for reverting is: proxies test failing
https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Str....

Powered by Google App Engine
This is Rietveld 408576698