Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1211443002: Expose Resource Timing methods and attribute in workers (Closed)

Created:
5 years, 6 months ago by Kunihiko Sakamoto
Modified:
5 years, 6 months ago
Reviewers:
kinuko, tkent
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose Resource Timing methods and attribute in workers This patch makes the Resource Timing extensions to the Performance interface [1] available in Workers, behind the experimental flag. Unfortunately those are still prefixed in window.performance, so prefixed in workers too. Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/htsW078UcFA [1] http://www.w3.org/TR/resource-timing/#extensions-performance-interface BUG=465641 TEST=http/tests/workers,http/tests/serviceworker Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197713

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M LayoutTests/http/tests/workers/resources/performance-timeline-worker.js View 1 chunk +9 lines, -1 line 1 comment Download
M Source/core/timing/WorkerPerformance.idl View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
Kunihiko Sakamoto
5 years, 6 months ago (2015-06-24 06:57:01 UTC) #2
kinuko
lgtm It'd be nice to unprefix these but it'd need different intent/process... https://codereview.chromium.org/1211443002/diff/1/LayoutTests/http/tests/workers/resources/performance-timeline-worker.js File LayoutTests/http/tests/workers/resources/performance-timeline-worker.js ...
5 years, 6 months ago (2015-06-24 07:11:26 UTC) #3
tkent
lgtm https://codereview.chromium.org/1211443002/diff/1/Source/core/timing/WorkerPerformance.idl File Source/core/timing/WorkerPerformance.idl (right): https://codereview.chromium.org/1211443002/diff/1/Source/core/timing/WorkerPerformance.idl#newcode43 Source/core/timing/WorkerPerformance.idl:43: [RuntimeEnabled=ServiceWorkerPerformanceTimeline, MeasureAs=PrefixedPerformanceClearResourceTimings] void webkitClearResourceTimings(); It's unfortunate to ship ...
5 years, 6 months ago (2015-06-24 07:12:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211443002/1
5 years, 6 months ago (2015-06-24 08:00:12 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 08:04:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197713

Powered by Google App Engine
This is Rietveld 408576698