Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1211433002: Removing unused functions from WebSocketHandshakeResponse class (Closed)

Created:
5 years, 6 months ago by shiva.jm
Modified:
5 years, 6 months ago
Reviewers:
pdr., Mike West
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing unused functions from WebSocketHandshakeResponse class This patch removes the following unused function: WebSocketHandshakeResponse::clearHeaderFields(). BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/platform/network/WebSocketHandshakeResponse.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/network/WebSocketHandshakeResponse.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
shiva.jm
pls have a look.
5 years, 6 months ago (2015-06-24 06:17:10 UTC) #2
Mike West
LGTM if everything compiles.
5 years, 6 months ago (2015-06-24 07:20:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211433002/1
5 years, 6 months ago (2015-06-24 08:22:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-24 09:23:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211433002/1
5 years, 6 months ago (2015-06-24 09:29:25 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 09:33:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197721

Powered by Google App Engine
This is Rietveld 408576698