Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1211413003: Make SkPaint::glyphsToUnichars use explicit SkSurfaceProps (Closed)

Created:
5 years, 6 months ago by robertphillips
Modified:
5 years, 6 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkPaint::glyphsToUnichars use explicit SkSurfaceProps BUG=skia:3984, skia:3934 Committed: https://skia.googlesource.com/skia/+/d24955ad3511a024206dd2ac893b52aa85d6cd30

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M include/core/SkPaint.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkPaint.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
robertphillips
5 years, 6 months ago (2015-06-26 15:56:02 UTC) #2
robertphillips
5 years, 6 months ago (2015-06-26 15:57:04 UTC) #3
robertphillips
PTAL - addressed in person comments
5 years, 6 months ago (2015-06-26 18:50:42 UTC) #5
reed1
lgtm
5 years, 6 months ago (2015-06-26 18:52:39 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211413003/20001
5 years, 6 months ago (2015-06-26 19:04:12 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-26 19:10:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211413003/20001
5 years, 6 months ago (2015-06-26 19:17:24 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 19:18:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d24955ad3511a024206dd2ac893b52aa85d6cd30

Powered by Google App Engine
This is Rietveld 408576698