[Instant] Instant Extended tests for search term extraction.

chrome/browser/instant/instant_test_utils.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/instant/instant_test_utils.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url_service.h"
@@ skipping 47 matching lines @@
       switches::kInstantURL, instant_url_.spec());
   SetupInstantUsingTemplateURL();
 }
 
 void InstantTestBase::SetupInstantUsingTemplateURL() {
   TemplateURLService* service =
       TemplateURLServiceFactory::GetForProfile(browser()->profile());
   ui_test_utils::WaitForTemplateURLServiceToLoad(service);
 
   TemplateURLData data;
-  data.SetURL("http://does/not/exist?q={searchTerms}");
+  // Necessary to use exact URL for search term extraction to work in
+  // InstantExtended.
+  data.SetURL(instant_url_.spec() + "?espv=1&q={searchTerms}");

[sreeram, 2013/02/01 22:03:24]

I'd like to keep data.SetURL("http://does/not/exist?q={searchTerms}"). I think
search terms extraction works on alternate URLs, so it should suffice to set
alternate_urls to a real URL, as you have on the next line.

[Mathieu, 2013/02/04 20:37:36]

Unfortunately the template URLs are looked up by domain, so having a mismatch
between the "main" URL and the alternate makes it fail. 

+  data.alternate_urls.push_back(instant_url_.spec() +
+                                "?espv=1#q={searchTerms}");

[sreeram, 2013/02/01 22:03:24]

instant_url_.spec() already has "?espv=1" (in the case of
instant_extended_browsertest.cc), so aren't you adding it twice here?

[Mathieu, 2013/02/04 20:37:36]

Done.

+  data.search_terms_replacement_key = "espv";

[sreeram, 2013/02/01 22:03:24]

Don't use "espv". Use some bogus value (here and in
instant_extended_browsertest.cc). Perhaps "strk" (acronym for "search terms
replacement key"). This will let us catch mistakes where we accidentally rely on
the actual string "espv" instead of using the correct
search_terms_replacement_key from the template.

[Mathieu, 2013/02/04 20:37:36]

Done.

   data.instant_url = instant_url_.spec();
 
   TemplateURL* template_url = new TemplateURL(browser()->profile(), data);
   service->Add(template_url);  // Takes ownership of |template_url|.
   service->SetDefaultSearchProvider(template_url);
   browser()->profile()->GetPrefs()->SetBoolean(prefs::kInstantEnabled, true);
 }
 
 void InstantTestBase::KillInstantRenderView() {
   base::KillProcess(
@@ skipping 59 matching lines @@
 }
 
 bool InstantTestBase::CheckVisibilityIs(content::WebContents* contents,
                                         bool expected) {
   bool actual = !expected;  // Purposely start with a mis-match.
   // We can only use ASSERT_*() in a method that returns void, hence this
   // convoluted check.
   return GetBoolFromJS(contents, "!document.webkitHidden", &actual) &&
       actual == expected;
 }