Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 12114040: Add state INPUT_EVENT_ACK_STATE_UNKNOWN (Closed)

Created:
7 years, 10 months ago by Yusuf
Modified:
7 years, 10 months ago
Reviewers:
Ted C, sadrul
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add state INPUT_EVENT_ACK_STATE_UNKNOWN This was added for CrOS support for touch event tracking, currently causes us to misinterpret the acks we are receiving. BUG=168350 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuf
7 years, 10 months ago (2013-02-01 00:03:53 UTC) #1
Ted C
lgtm
7 years, 10 months ago (2013-02-01 00:22:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/12114040/1
7 years, 10 months ago (2013-02-01 00:50:17 UTC) #3
nduca
NOTRY=True, 5 hours is too long to wait for an urgent fix to touch on ...
7 years, 10 months ago (2013-02-01 05:53:43 UTC) #4
nduca
Committed manually as r180091 (presubmit successful).
7 years, 10 months ago (2013-02-01 05:55:38 UTC) #5
sadrul
7 years, 10 months ago (2013-02-01 07:31:10 UTC) #6
Message was sent while issue was closed.
My bad. I relied too heavily on git-gs to tell me if this was used elsewhere.
Hopefully https://codereview.chromium.org/12094102/ will help avoid such cases
in the future.

Powered by Google App Engine
This is Rietveld 408576698