Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 12114008: Avoid re-tagging of the index register in optimized byte array access. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_x64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_x64.cc (revision 18444)
+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)
@@ -1322,25 +1322,6 @@
}
-void FlowGraphCompiler::LoadDoubleOrSmiToFpu(FpuRegister result,
- Register reg,
- Register temp,
- Label* not_double_or_smi) {
- Label is_smi, done;
- __ testq(reg, Immediate(kSmiTagMask));
- __ j(ZERO, &is_smi);
- __ CompareClassId(reg, kDoubleCid);
- __ j(NOT_EQUAL, not_double_or_smi);
- __ movsd(result, FieldAddress(reg, Double::value_offset()));
- __ jmp(&done);
- __ Bind(&is_smi);
- __ movq(temp, reg);
- __ SmiUntag(temp);
- __ cvtsi2sd(result, temp);
- __ Bind(&done);
-}
-
-
void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) {
// TODO(vegorov): consider saving only caller save (volatile) registers.
const intptr_t xmm_regs_count = locs->live_registers()->fpu_regs_count();

Powered by Google App Engine
This is Rietveld 408576698