Avoid re-tagging of the index register in optimized byte array access.

runtime/vm/flow_graph_compiler_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 1300 matching lines @@
   __ Drop(1);
   __ jmp(skip_call);
   __ Bind(&is_false);
   __ LoadObject(result, Bool::False());
   __ Drop(1);
   __ jmp(skip_call);
   __ Bind(&fall_through);
 }
 
 
-void FlowGraphCompiler::LoadDoubleOrSmiToFpu(FpuRegister result,
-                                             Register reg,
-                                             Register temp,
-                                             Label* not_double_or_smi) {
-  Label is_smi, done;
-  __ testl(reg, Immediate(kSmiTagMask));
-  __ j(ZERO, &is_smi);
-  __ CompareClassId(reg, kDoubleCid, temp);
-  __ j(NOT_EQUAL, not_double_or_smi);
-  __ movsd(result, FieldAddress(reg, Double::value_offset()));
-  __ jmp(&done);
-  __ Bind(&is_smi);
-  __ movl(temp, reg);
-  __ SmiUntag(temp);
-  __ cvtsi2sd(result, temp);
-  __ Bind(&done);
-}
-
-
 void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) {
   // TODO(vegorov): consider saving only caller save (volatile) registers.
   const intptr_t xmm_regs_count = locs->live_registers()->fpu_regs_count();
   if (xmm_regs_count > 0) {
     __ subl(ESP, Immediate(xmm_regs_count * kDoubleSize));
     // Store XMM registers with the lowest register number at the lowest
     // address.
     intptr_t offset = 0;
     for (intptr_t reg_idx = 0; reg_idx < kNumberOfXmmRegisters; ++reg_idx) {
       XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx);
@@ skipping 372 matching lines @@
   __ popl(ECX);
   __ popl(EAX);
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32