Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1211383002: Revert of [android] Migrate more configs to gyp. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
CC:
v8-dev, chunyang.dai, balazs.kilvady, paul.l...
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [android] Migrate more configs to gyp. (patchset #4 id:60001 of https://codereview.chromium.org/1207693004/) Reason for revert: Breaks arm64 bots. Original issue's description: > [android] Migrate more configs to gyp. > > BUG=chromium:502176 > LOG=n > > Committed: https://crrev.com/174869573e42c999da1489c264b9c4602b98ba31 > Cr-Commit-Position: refs/heads/master@{#29314} TBR=jochen@chromium.org,ulan@chromium.org,dusan.milosavljevic@imgtec.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:502176 Committed: https://crrev.com/3e8892b589f16454d4f592e2ed3f6d4ddf0a0bc6 Cr-Commit-Position: refs/heads/master@{#29316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -30 lines) Patch
M Makefile.android View 1 chunk +11 lines, -7 lines 0 comments Download
M build/standalone.gypi View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [android] Migrate more configs to gyp.
5 years, 6 months ago (2015-06-26 10:02:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211383002/1
5 years, 6 months ago (2015-06-26 10:02:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-26 10:02:23 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 10:02:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e8892b589f16454d4f592e2ed3f6d4ddf0a0bc6
Cr-Commit-Position: refs/heads/master@{#29316}

Powered by Google App Engine
This is Rietveld 408576698