Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1211373002: [turbofan] Canonicalize return sequence for JSFunctions. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Canonicalize return sequence for JSFunctions. This optimization is already implemented in fullcodegen, and basically makes sure that we do not unecessarily blow up the code with duplicated return sequences everywhere. R=danno@chromium.org Committed: https://crrev.com/2b9112a578f66fc976557aededf3e203f48c395e Cr-Commit-Position: refs/heads/master@{#29315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -43 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +13 lines, -7 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 5 months ago (2015-06-26 08:45:36 UTC) #1
Benedikt Meurer
Hey Danno, This is the optimization we just talked about. Please take a look. Thanks, ...
5 years, 5 months ago (2015-06-26 08:47:27 UTC) #2
Jarin
lgtm
5 years, 5 months ago (2015-06-26 09:19:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211373002/1
5 years, 5 months ago (2015-06-26 09:19:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-26 09:34:37 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-26 09:34:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b9112a578f66fc976557aededf3e203f48c395e
Cr-Commit-Position: refs/heads/master@{#29315}

Powered by Google App Engine
This is Rietveld 408576698