Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1211333004: Add arm glibc support for gyp build (Closed)

Created:
5 years, 5 months ago by Sam Clegg
Modified:
5 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Add arm glibc support for gyp build The new blocks in untrusted.gypi are essentially copies of the x86 blocks. BUG= https://code.google.com/p/chromium/issues/detail?id=505885 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/efd02a4a4bcb4f4b2583f608004f5c3def6ac59d

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -5 lines) Patch
M build/build_nexe.py View 1 chunk +0 lines, -3 lines 0 comments Download
M build/untrusted.gypi View 1 4 chunks +84 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Sam Clegg
5 years, 5 months ago (2015-06-30 18:10:59 UTC) #2
bradn
lgtm
5 years, 5 months ago (2015-06-30 18:14:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211333004/20001
5 years, 5 months ago (2015-06-30 20:09:32 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 01:03:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/efd02a4a4...

Powered by Google App Engine
This is Rietveld 408576698