Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1211323013: Stop calling deprecated version of "CreateIceCandidate". (Closed)

Created:
5 years, 5 months ago by joachim
Modified:
5 years, 5 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop calling deprecated version of "CreateIceCandidate". In WebRTC the three-argument function is marked as deprecated, pass the additional parameter here so the deprecated function can go away. Committed: https://crrev.com/7dee3f68b7699ad72c7fc4d75332f72703313849 Cr-Commit-Position: refs/heads/master@{#337581}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use nullptr instead of NULL. #

Total comments: 2

Patch Set 3 : Fixed indent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/cast_extension_session.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
joachim
PTAL
5 years, 5 months ago (2015-07-01 23:11:03 UTC) #2
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/1211323013/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc File content/renderer/media/webrtc/peer_connection_dependency_factory.cc (right): https://codereview.chromium.org/1211323013/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc#newcode572 content/renderer/media/webrtc/peer_connection_dependency_factory.cc:572: return webrtc::CreateIceCandidate(sdp_mid, sdp_mline_index, sdp, NULL); nit: nullptr https://codereview.chromium.org/1211323013/diff/1/remoting/host/cast_extension_session.cc ...
5 years, 5 months ago (2015-07-02 11:24:31 UTC) #3
joachim
Thanks. @Sergey: PTAL remoting/ https://codereview.webrtc.org/1211323013/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc File content/renderer/media/webrtc/peer_connection_dependency_factory.cc (right): https://codereview.webrtc.org/1211323013/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc#newcode572 content/renderer/media/webrtc/peer_connection_dependency_factory.cc:572: return webrtc::CreateIceCandidate(sdp_mid, sdp_mline_index, sdp, NULL); ...
5 years, 5 months ago (2015-07-02 12:01:23 UTC) #4
Sergey Ulanov
lgtm https://codereview.chromium.org/1211323013/diff/20001/remoting/host/cast_extension_session.cc File remoting/host/cast_extension_session.cc (right): https://codereview.chromium.org/1211323013/diff/20001/remoting/host/cast_extension_session.cc#newcode393 remoting/host/cast_extension_session.cc:393: nullptr)); please fix indentation. This argument should be ...
5 years, 5 months ago (2015-07-06 18:03:19 UTC) #5
joachim
Thanks https://codereview.webrtc.org/1211323013/diff/20001/remoting/host/cast_extension_session.cc File remoting/host/cast_extension_session.cc (right): https://codereview.webrtc.org/1211323013/diff/20001/remoting/host/cast_extension_session.cc#newcode393 remoting/host/cast_extension_session.cc:393: nullptr)); On 2015/07/06 18:03:19, Sergey Ulanov wrote: > ...
5 years, 5 months ago (2015-07-07 08:52:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211323013/40001
5 years, 5 months ago (2015-07-07 08:52:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/41388) (exceeded global retry quota)
5 years, 5 months ago (2015-07-07 09:33:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211323013/40001
5 years, 5 months ago (2015-07-07 10:35:03 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-07 10:40:59 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 10:42:03 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7dee3f68b7699ad72c7fc4d75332f72703313849
Cr-Commit-Position: refs/heads/master@{#337581}

Powered by Google App Engine
This is Rietveld 408576698