[Telemetry] Remove adb_commands usage from android_device

build/android/pylib/device/device_utils.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides a variety of device interactions based on adb.
 
 Eventually, this will be based on adb_wrapper.
 """
 # pylint: disable=unused-argument
 
@@ skipping 1726 matching lines @@
   def HealthyDevices(cls):
     blacklist = device_blacklist.ReadBlacklist()
     def blacklisted(adb):
       if adb.GetDeviceSerial() in blacklist:
         logging.warning('Device %s is blacklisted.', adb.GetDeviceSerial())
         return True
       return False
 
     return [cls(adb) for adb in adb_wrapper.AdbWrapper.Devices()
             if not blacklisted(adb)]
+
+  @classmethod
+  def GetAttachedDevices(cls):

[jbudorick, 2015/06/29 17:56:23]

I would prefer to not add this here. Generally, clients should be using
HealthyDevices -- we blacklist things for a reason. If clients want to use
blacklisted devices, I think it's ok if they use AdbWrapper directly.

[nednguyen, 2015/06/29 17:59:12]

Ok. But I am curious about this black listing strategy. How would you make
pylib/ an open source project with a hard coded list of device ids?

[jbudorick, 2015/06/29 18:03:45]

...?

We don't have a hard-coded list of device IDs. Blacklisting is done on a per-run
basis and is handled by
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli....
Typically, we blacklist devices for misbehaving in device_status_check or
provision_devices.

[nednguyen, 2015/06/29 18:14:54]

By hard coded, I mean the path to json file bad_devices.json. But look like we
should be able to make this configurable.

[jbudorick, 2015/06/29 18:27:44]

Oh, yeah. That part is hard-coded, but I don't think it'll be terribly difficult
to change that for extraction from chromium. I thought you meant a hard-coded
list of device IDs.

[nednguyen, 2015/06/29 18:42:05]

Done.

+    return [cls(adb) for adb in adb_wrapper.AdbWrapper.Devices()]