Issue 1211293003: CacheStorage: Cache::putImpl should call onError in early-return cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1211293003: CacheStorage: Cache::putImpl should call onError in early-return cases (Closed)

Created:
5 years, 5 months ago by nhiroki

Modified:
5 years, 5 months ago

Reviewers:
jkarlin

CC:
blink-reviews, sof, serviceworker-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

CacheStorage: Cache::putImpl should call onError in early-return cases Otherwise, ScriptPromiseResolver created in Cache::putImpl could cause an assertion failure on its dtor because the resolver is never resolved or rejected. BUG=427652 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198145

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
	M	Source/modules/cachestorage/Cache.cpp	View		2 chunks	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211293003/1

5 years, 5 months ago (2015-07-01 13:47:49 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-01 14:30:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198145

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages