media/audio/alsa/alsa_output_unittest.cc - Issue 1211273005: Use safer IPC serializations in media_param_traits.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/alsa/alsa_output_unittest.cc

Issue 1211273005: Use safer IPC serializations in media_param_traits.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try harder to force invalid enum values Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/alsa/alsa_output_unittest.cc

diff --git a/media/audio/alsa/alsa_output_unittest.cc b/media/audio/alsa/alsa_output_unittest.cc

index c9a98c519ceba5c81f6b0186c1e80f81e7345a8d..0a9119a2cdb9e6c03bc9346fb5cf5224f2cc16f3 100644

--- a/media/audio/alsa/alsa_output_unittest.cc

+++ b/media/audio/alsa/alsa_output_unittest.cc

@@ -237,9 +237,10 @@ TEST_F(AlsaPcmOutputStreamTest, ConstructedState) {

test_stream->Close();

// Bad format.

- AudioParameters bad_format_params(

- AudioParameters::AUDIO_LAST_FORMAT, kTestChannelLayout, kTestSampleRate,

- kTestBitsPerSample, kTestFramesPerPacket);

+ AudioParameters bad_format_params(static_cast<AudioParameters::Format>(

+ AudioParameters::AUDIO_FORMAT_LAST + 1),

+ kTestChannelLayout, kTestSampleRate,

+ kTestBitsPerSample, kTestFramesPerPacket);

test_stream = new AlsaPcmOutputStream(kTestDeviceName,

bad_format_params,

&mock_alsa_wrapper_,

« content/common/media/media_param_traits.cc ('K') | « content/common/view_messages.h ('k') | media/audio/android/audio_android_unittest.cc » ('j') | media/audio/audio_parameters.cc » ('J')