chrome/browser/BUILD.gn - Issue 1211273003: Disable "Ok Google" hotwording in open source builds by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 1211273003: Disable "Ok Google" hotwording in open source builds by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hotword-clarify-labels

Patch Set: Rebase properly. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 6ccb0796337580185dd051e69884db8e882d3160..8b7e0fe08f8b4fa4a1361d9404c08c1f09cd937d 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -19,8 +19,10 @@ if (is_desktop_linux) {

}

declare_args() {

- # 'Ok Google' hotwording is enabled.

- enable_hotwording = true

+ # 'Ok Google' hotwording is disabled by default in open source builds. Set to

+ # true to enable. (This will download a closed-source NaCl module at startup.)

+ # Chrome-branded builds have this enabled by default.

+ enable_hotwording = is_chrome_branded

}

about_credits_file = "$target_gen_dir/about_credits.html"

« no previous file with comments | « build/common.gypi ('k') | chrome/browser/search/hotword_service_unittest.cc » ('j') | no next file with comments »