Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1211253009: Set exception whitelist check as earlier check instead of last check. (Closed)

Created:
5 years, 5 months ago by liuandrew
Modified:
5 years, 5 months ago
Reviewers:
ivanpe
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Set exception whitelist check as earlier check instead of last check. When I first added the exception whitelist, I meant to put the check before checking the location of the instruction pointer. (I didn't notice that it was after the other check until now.) The whitelist check is to quickly rule out minidumps, and if checking the instruction pointer provided any useful information, it would be pretty indicative that the exception causing the dump is interesting. R=ivanpe@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M src/processor/exploitability_linux.cc View 3 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
liuandrew
5 years, 5 months ago (2015-07-07 20:26:50 UTC) #2
ivanpe
On 2015/07/07 20:26:50, liuandrew wrote: LGTM
5 years, 5 months ago (2015-07-07 21:28:59 UTC) #3
liuandrew
5 years, 5 months ago (2015-07-07 21:30:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r1469 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698