Issue 1211253004: Add MineDigger.apk that works offline

Issue 1211253004: Add MineDigger.apk that works offline (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add MineDigger.apk that works offline This CL builds an APK for MineDigger that works offline. We use |sky_packager| to snapshot the Dart code, which we then extract from the APK during startup. If we succeed in extracting a snapshot, we load it by default. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/60eff19e7fbe10d8e1ddd8061e4d8ef8a6880cce

Patch Set 1 #

Patch Set 2 : Update home.dart #

Patch Set 3 : Fix typo #

Patch Set 4 : rebase #

Patch Set 5 : one more examples #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -425 lines)			Patch
M	sky/BUILD.gn	View	1 2 3	3 chunks	+1 line, -7 lines	0 comments	Download
M	sky/apk/rules.gni	View		1 chunk	+76 lines, -0 lines	0 comments	Download
M	sky/sdk/BUILD.gn	View		1 chunk	+5 lines, -1 line	0 comments	Download
A +	sky/sdk/example/BUILD.gn	View	1 2 3	1 chunk	+7 lines, -5 lines	0 comments	Download
A +	sky/sdk/example/mine_digger/BUILD.gn	View	1 2 3	1 chunk	+6 lines, -5 lines	0 comments	Download
A +	sky/sdk/example/mine_digger/apk/AndroidManifest.xml	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
A +	sky/sdk/example/mine_digger/lib/main.dart	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	sky/sdk/example/mine_digger/mine_digger.dart	View	1 2 3	1 chunk	+0 lines, -373 lines	0 comments	Download
A	sky/sdk/example/mine_digger/pubspec.yaml	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sky/sdk/home.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/services/viewport/viewport_observer.mojom	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyActivity.java	View		3 chunks	+13 lines, -0 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyApplication.java	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	sky/shell/linux/main.cc	View		4 chunks	+7 lines, -20 lines	0 comments	Download
M	sky/shell/ui/engine.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View		3 chunks	+17 lines, -3 lines	0 comments	Download
M	sky/tools/packager/main.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
A	sky/tools/sky_packager.py	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-06-27 06:18:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
60eff19e7fbe10d8e1ddd8061e4d8ef8a6880cce (presubmit successful).

Expand Messages | Collapse Messages