[Service Worker Registration] Registered extension scheme to allow service workers

extensions/renderer/service_worker_apitest.cc

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.

[Devlin, 2015/07/10 21:51:23]

nit: no (c)

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_apitest.h"

[Devlin, 2015/07/10 21:51:23]

This would be a layering violation (no chrome/ files in top-level extensions/),
but we can just put this whole thing in chrome/browser/extensions/.

+
+namespace extensions {
+namespace {

[Devlin, 2015/07/10 21:51:23]

No need to put this in an anonymous namespace (I don't know why some tests do)

+
+class ServiceWorkerTest : public ExtensionApiTest {
+public:

[Devlin, 2015/07/10 21:51:23]

nit: indentation is off.  You can also use "git cl format" to handle little
style things like this.

+  // Set the channel to "trunk" since service workers are restricted to trunk.
+  ServiceWorkerTest()
+    : current_channel_(chrome::VersionInfo::CHANNEL_UNKNOWN) {}
+  ~ServiceWorkerTest() override {}
+
+private:
+  extensions::ScopedCurrentChannel current_channel_;

[Devlin, 2015/07/10 21:51:23]

DISALLOW_COPY_AND_ASSIGN()

+};
+
+// This should fail because there are changes to be made to
+// successfully register a service worker.
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, RegisterServiceWorker) {

[Devlin, 2015/07/10 21:51:23]

Let's have two tests, one that checks that service worker registration always
fails with the channel as, say, dev (bumped to beta or stable as we begin
releasing), and one that tests that service worker registration gets as far as
we have with the other scope.  This will probably mean you need two test classes
(or a templated one, if you feel brave), since the channel needs to be set up
pretty early on.

+  ASSERT_FALSE(RunExtensionTest("service_worker/register")) << message_;
+}
+
+}  // namespace
+}  // namespace extensions