[Service Worker Registration] Registered extension scheme to allow service workers

chrome/test/data/extensions/api_test/service_worker/register/test.js

+var registered = false;

[Devlin, 2015/07/10 21:51:23]

nit: you'll need the license in .js files, too. (.json and .html files are
exempt)

+var error_msg = "";

[Devlin, 2015/07/10 21:51:23]

nitty nit: prefer single quotes, unless you have a quote with quotes.

+

[not at google - send to devlin, 2015/07/10 22:00:42]

also, JS style is camelcase unlike C++.

+chrome.test.runTests([
+  function registerServiceWorker() {
+    if ('serviceWorker' in navigator) {

[Devlin, 2015/07/10 21:51:23]

We can probably ignore this - chrome always has serviceWorker. :)

+        navigator.serviceWorker.register('/sw.js').then(function(registration) {
+          // Registration was successful
+          console.log('ServiceWorker registration successful with scope: ',

[Devlin, 2015/07/10 21:51:22]

We're not supposed to spam the log with status from tests, because it can make a
lot of noise.  Of course, most people ignore this.  That said, let's be good
citizens :)  These logs can be handy in debugging, though, so I sometimes see
the pattern of

var logForDebugging = false;
function log(message) {
  if (logForDebugging)
    console.log(message);
}

Then, when you're debugging, you just flip the logForDebugging bit.

+            registration.scope);
+          registered = true;
+      }).catch(function(err) {
+          // registration failed :(
+          error_msg = err.name + ': ' + err.message;
+          console.log('ServiceWorker registration failed: ' + error_msg);
+          // This is the error message that should appear when the extension
+          // scheme is registered to allow service workers
+          chrome.test.assertEq('SecurityError: Failed to register a'

[Devlin, 2015/07/10 21:51:23]

For this test extension, how about we use chrome.test.sendMessage() (see
ExtensionTestMessageListener for examples) to forward either a "success"
message, or the error?  That way, we can re-use it for both the "fails when
channel is wrong" and "gets as far as we can" tests.

+            + 'ServiceWorker: No URL is associated with the caller\'s'

[Devlin, 2015/07/10 21:51:23]

nitty nit: prefer double quotes when you have a quote with single quotes in it.

+            + ' document.', error_msg);
+      });
+    }
+    chrome.test.assertTrue(registered);
+  }
+]);
+