[Service Worker Registration] Registered extension scheme to allow service workers

chrome/test/data/extensions/api_test/service_worker/register/test.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var logForDebugging = false;
+function log(message) {
+  if (logForDebugging)
+    console.log(message);
+}
+
+chrome.test.runTests([
+  function registerServiceWorker() {
+    var registered = false;
+    navigator.serviceWorker.register('/sw.js').then(function(registration) {
+      // Registration was successful
+      log('ServiceWorker registration successful with scope: ',
+        registration.scope);

[Devlin, 2015/07/13 21:22:11]

nit: indentation.

[annekao, 2015/07/13 21:30:47]

Should the next line line up with the quote?

[Devlin, 2015/07/13 21:46:16]

Yes.  You actually have two choices
- you can line up each parameter:
MyMethod(MethodArgument1,
         MethodArgument2);
- or you can use 4-space indentation for a line continuation:
MyMethod(
    MethodArgument1,
    MethodArgument2);

(preferring the former if it fits)

Interestingly, in this case, 4-space indentation puts it at the same spot :)

[annekao, 2015/07/13 22:21:29]

Done.

+      registered = true;
+      chrome.test.sendMessage("success");
+    }).catch(function(err) {
+      // registration failed :(
+      var errorMsg = err.name + ': ' + err.message;
+      log('ServiceWorker registration failed: ' + errorMsg);
+      chrome.test.sendMessage(errorMsg);
+    });
+    chrome.test.assertTrue(registered);

[Devlin, 2015/07/13 21:22:11]

hmm... since registration is asynchronous, would this ever succeed?  I think
this would be better as having a chrome.test.succeed() in the resolve, and
chrome.test.fail() in the reject.

[annekao, 2015/07/13 22:21:29]

Done.

+  }
+]);
+

[Devlin, 2015/07/13 21:22:11]

remove empty blank line.

[annekao, 2015/07/13 22:21:29]

Done.