[Service Worker Registration] Registered extension scheme to allow service workers

chrome/browser/extensions/service_worker_apitest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_apitest.h"
+#include "extensions/test/extension_test_message_listener.h"
+
+namespace extensions {
+
+class ServiceWorkerTest : public ExtensionApiTest {
+ public:
+  // Set the channel to "trunk" since service workers are restricted to trunk.
+  ServiceWorkerTest()
+      : current_channel_(chrome::VersionInfo::CHANNEL_UNKNOWN) {}
+
+  ~ServiceWorkerTest() override {}
+
+ private:
+  extensions::ScopedCurrentChannel current_channel_;
+  DISALLOW_COPY_AND_ASSIGN(ServiceWorkerTest);
+};
+
+// This should fail because there are changes to be made to
+// successfully register a service worker.
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, RegisterServiceWorkerTrunk) {
+  ExtensionTestMessageListener listener(false);
+  ASSERT_FALSE(RunExtensionTest("service_worker/register")) << message_;
+  ASSERT_TRUE(listener.WaitUntilSatisfied());
+  if (listener.message() != "success") {

[Devlin, 2015/07/13 19:32:24]

Instead of this, we should just assert that the error message *is* the expected
one.  After all, we don't expect it to succeed, right?

(Same with below)

[annekao, 2015/07/13 21:15:59]

Done.

+    ASSERT_EQ(
+        "SecurityError: Failed to register a ServiceWorker: No URL is "
+        "associated with the caller's document.",
+        listener.message());
+  }
+}
+
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, RegisterServiceWorkerDev) {

[Devlin, 2015/07/13 19:32:24]

Maybe rename this to "CannotRegisterServiceWorkersOnDev" with a comment about
why dev is significant?  (The feature is restricted to trunk, so on dev it
should have existing behavior - which is for it to fail.)

[annekao, 2015/07/13 21:15:59]

Done.

+  extensions::ScopedCurrentChannel current_channel_override(

[Devlin, 2015/07/13 19:32:24]

nit: this is already in the extensions namespace, so you don't need the prefix
(everywhere in this file).

[annekao, 2015/07/13 21:15:59]

Done.

+      chrome::VersionInfo::CHANNEL_DEV);
+  ExtensionTestMessageListener listener(false);
+  ASSERT_FALSE(RunExtensionTest("service_worker/register")) << message_;
+  ASSERT_TRUE(listener.WaitUntilSatisfied());
+  if (listener.message() != "success") {
+    ASSERT_EQ(
+        "SecurityError: Failed to register a ServiceWorker: The URL "
+        "protocol of the current origin ('chrome-extension://" +
+            GetSingleLoadedExtension()->id() + "') is not supported.",
+        listener.message());
+  }
+}
+
+}  // namespace extensions