Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1211243007: [turbofan] Disable recursive inlining for now. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable recursive inlining for now. The deoptimizer (and probably various other places) cannot deal properly with recursive function inlining, so we disallow it in TurboFan as well. We might want to reconsider that decision at some point in the future. R=jarin@chromium.org Committed: https://crrev.com/9dccfea020b2cd0bedda7e633c19d49e9f681f6e Cr-Commit-Position: refs/heads/master@{#29374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M src/compiler/js-inlining.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-06-30 10:39:22 UTC) #1
Benedikt Meurer
Hey Jaro, Obvious one. Please take a look. Thanks, Benedikt
5 years, 5 months ago (2015-06-30 10:39:48 UTC) #2
Jarin
lgtm
5 years, 5 months ago (2015-06-30 10:44:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211243007/1
5 years, 5 months ago (2015-06-30 10:45:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 11:05:10 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 11:05:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dccfea020b2cd0bedda7e633c19d49e9f681f6e
Cr-Commit-Position: refs/heads/master@{#29374}

Powered by Google App Engine
This is Rietveld 408576698